Stop ignoring `.bazelbsp` in REPO.bazel by rdesgroppes · Pull Request #48585 · DataDog/datadog-agent

rdesgroppes · 2026-03-30T12:57:53Z

What does this PR do?

Replace the alas too broad .* pattern in ignore_directories (since #48525, my bad) with more fine-grained patterns (.c*, .d*, .g*, .i*, .v*, .*_cache) that cover the same hidden directories while leaving .bazelbsp visible to bazel.

Motivation

IDE like IntelliJ IDEA and GoLand use the Bazel BSP (Build Server Protocol) integration, whose state lives in .bazelbsp/.
The ".*" catch-all caused Bazel to skip that directory, so these IDEs stopped refreshing the project.

ignore_directories has no negation syntax, so enumerating more fine-grained patterns is the only available workaround.

Describe how you validated your changes

Verified that .bazelbsp no longer appears in the ignored set and that all previously-ignored hidden directories still match at least one of the new patterns.

Additional Notes

I'll file an issue upstream to request ignore_directories gets augmented with an exclude=[] arg, just like glob.

### What does this PR do? Replace the alas too broad `.*` pattern in `ignore_directories` with more fine-grained patterns (`.c*`, `.d*`, `.g*`, `.i*`, `.v*`, `.*_cache`) that cover the same hidden directories while leaving `.bazelbsp` visible to `bazel`. ### Motivation IDE like IntelliJ IDEA and GoLand use the Bazel BSP (Build Server Protocol) integration, whose state lives in `.bazelbsp/`. The `".*"` catch-all caused Bazel to skip that directory, so these IDEs stopped refreshing the project. `ignore_directories` has no negation syntax, so enumerating more fine-grained patterns is the only available workaround. ### Describe how you validated your changes Verified that `.bazelbsp` no longer appears in the ignored set and that all previously-ignored hidden directories still match at least one of the new patterns. ### Additional Notes I'll file an issue upstream to request `ignore_directories` gets augmented with an `exclude=[]` arg like [glob](https://bazel.build/reference/be/functions#glob).

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc886276e5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

REPO.bazel

agent-platform-auto-pr · 2026-03-30T13:23:34Z

Files inventory check summary

File checks results against ancestor 353d0570:

Results for datadog-agent_7.79.0~devel.git.266.fc88627.pipeline.105018780-1_amd64.deb:

No change detected

cit-pr-commenter-54b7da · 2026-03-30T16:43:22Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 69361ae9-806c-490a-b47c-07ac151ea278

Baseline: d8bb8d2
Comparison: 09ec021
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-1.76	[-4.72, +1.20]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	ddot_logs	memory utilization	+0.63	[+0.55, +0.70]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.48	[+0.35, +0.60]	1	Logs
➖	docker_containers_memory	memory utilization	+0.37	[+0.29, +0.45]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.32	[+0.20, +0.43]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.05	[-0.33, +0.44]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.03	[-0.14, +0.21]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.01	[-0.21, +0.24]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.01	[-0.03, +0.05]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.19, +0.21]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.00	[-0.20, +0.19]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.12, +0.10]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.02	[-0.46, +0.42]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.10, +0.06]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.08	[-0.13, -0.02]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.08	[-0.61, +0.46]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.10	[-1.72, +1.52]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.14	[-0.18, -0.09]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.21	[-0.27, -0.15]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.24	[-0.39, -0.08]	1	Logs
➖	ddot_metrics	memory utilization	-0.34	[-0.53, -0.16]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.70	[-0.84, -0.56]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-1.33	[-1.56, -1.10]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-1.76	[-4.72, +1.20]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	704 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	274.27MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	701 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
❌	quality_gate_idle	memory_usage	9/10	175.14MiB > 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	492.54MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	203.74MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	355.25 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	423.26MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 30, 2026

rdesgroppes marked this pull request as ready for review March 30, 2026 12:59

rdesgroppes requested a review from a team as a code owner March 30, 2026 12:59

dd-octo-sts bot added the internal Identify a non-fork PR label Mar 30, 2026

github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 30, 2026

dd-octo-sts bot added the team/agent-build label Mar 30, 2026

chatgpt-codex-connector bot reviewed Mar 30, 2026

View reviewed changes

REPO.bazel Show resolved Hide resolved

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Mar 30, 2026

aiuto approved these changes Mar 30, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d bot merged commit 09ec021 into main Mar 30, 2026
267 checks passed

gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/repo-bazel-bazelbsp branch March 30, 2026 15:54

github-actions bot added this to the 7.79.0 milestone Mar 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stop ignoring `.bazelbsp` in REPO.bazel#48585

Stop ignoring `.bazelbsp` in REPO.bazel#48585
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/repo-bazel-bazelbsp

rdesgroppes commented Mar 30, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

agent-platform-auto-pr bot commented Mar 30, 2026

Uh oh!

Uh oh!

cit-pr-commenter-54b7da bot commented Mar 30, 2026

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rdesgroppes commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

agent-platform-auto-pr bot commented Mar 30, 2026

Files inventory check summary

Results for datadog-agent_7.79.0~devel.git.266.fc88627.pipeline.105018780-1_amd64.deb:

Uh oh!

Uh oh!

cit-pr-commenter-54b7da bot commented Mar 30, 2026

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rdesgroppes commented Mar 30, 2026 •

edited

Loading