Skip to content

host-profiler: set cgroup namespace to host in dev docker-compose#46654

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
nayef/host-profiler-cgroupns-host
Feb 19, 2026
Merged

host-profiler: set cgroup namespace to host in dev docker-compose#46654
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
nayef/host-profiler-cgroupns-host

Conversation

@Gandem
Copy link
Member

@Gandem Gandem commented Feb 18, 2026

What does this PR do?

Adds cgroup: "host" to the host-profiler service in the dev docker-compose, so the profiler gets the host cgroup namespace instead of a private one.

Motivation

On cgroup v2, Docker keeps private cgroup namespaces even for privileged containers (moby#40174). This causes /proc/self/cgroup to return 0::/, which breaks self container ID detection. Profiles of the profiler itself end up missing container tags.

Describe how you validated your changes

Run docker compose up --build from cmd/host-profiler/ and verify the profiler resolves its own container ID.

Additional Notes

This only affects the dev docker-compose. For customer-facing Docker deployments, we should add --cgroupns=host to the recommended run configuration in the docs.

@Gandem Gandem requested a review from a team as a code owner February 18, 2026 23:39
@Gandem Gandem requested a review from liustanley February 18, 2026 23:39
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2026 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Feb 18, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 18, 2026
@Gandem Gandem added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog No changelog entry needed labels Feb 18, 2026
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 19, 2026 •
edited
Loading

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 1f9eb16
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 756.183 MiB
✅ agent_deb_amd64_fips 715.062 MiB
✅ agent_heroku_amd64 323.706 MiB
✅ agent_msi 622.265 MiB
✅ agent_rpm_amd64 756.167 MiB
✅ agent_rpm_amd64_fips 715.046 MiB
✅ agent_rpm_arm64 734.403 MiB
✅ agent_rpm_arm64_fips 696.190 MiB
✅ agent_suse_amd64 756.167 MiB
✅ agent_suse_amd64_fips 715.046 MiB
✅ agent_suse_arm64 734.403 MiB
✅ agent_suse_arm64_fips 696.190 MiB
✅ docker_agent_amd64 817.229 MiB
✅ docker_agent_arm64 820.188 MiB
✅ docker_agent_jmx_amd64 1008.140 MiB
✅ docker_agent_jmx_arm64 999.882 MiB
✅ docker_cluster_agent_amd64 190.142 MiB
✅ docker_cluster_agent_arm64 205.566 MiB
✅ docker_cws_instrumentation_amd64 7.135 MiB
✅ docker_cws_instrumentation_arm64 6.689 MiB
✅ docker_dogstatsd_amd64 38.496 MiB
✅ docker_dogstatsd_arm64 36.812 MiB
✅ dogstatsd_deb_amd64 29.720 MiB
✅ dogstatsd_deb_arm64 27.877 MiB
✅ dogstatsd_rpm_amd64 29.720 MiB
✅ dogstatsd_suse_amd64 29.720 MiB
✅ iot_agent_deb_amd64 42.609 MiB
✅ iot_agent_deb_arm64 39.715 MiB
✅ iot_agent_deb_armhf 40.440 MiB
✅ iot_agent_rpm_amd64 42.610 MiB
✅ iot_agent_suse_amd64 42.610 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
✅ agent_deb_amd64 +41.06 KiB (0.02% increase) 185.588 → 185.628 → 186.090
✅ agent_deb_amd64_fips -42.47 KiB (0.02% reduction) 176.301 → 176.259 → 180.330
✅ agent_heroku_amd64 -3.72 KiB (0.00% reduction) 87.124 → 87.120 → 88.440
✅ agent_msi -4.0 KiB (0.00% reduction) 149.281 → 149.277 → 154.470
✅ agent_rpm_amd64 +3.69 KiB (0.00% increase) 187.562 → 187.566 → 189.170
✅ agent_rpm_amd64_fips -7.66 KiB (0.00% reduction) 178.430 → 178.422 → 181.060
✅ agent_rpm_arm64 -21.25 KiB (0.01% reduction) 169.810 → 169.789 → 170.020
✅ agent_rpm_arm64_fips +26.1 KiB (0.02% increase) 162.494 → 162.520 → 164.130
✅ agent_suse_amd64 +3.69 KiB (0.00% increase) 187.562 → 187.566 → 189.170
✅ agent_suse_amd64_fips -7.66 KiB (0.00% reduction) 178.430 → 178.422 → 181.060
✅ agent_suse_arm64 -21.25 KiB (0.01% reduction) 169.810 → 169.789 → 170.020
✅ agent_suse_arm64_fips +26.1 KiB (0.02% increase) 162.494 → 162.520 → 164.130
✅ docker_agent_amd64 +3.17 KiB (0.00% increase) 277.838 → 277.841 → 279.410
✅ docker_agent_arm64 neutral 265.116 MiB → 267.960
✅ docker_agent_jmx_amd64 +2.71 KiB (0.00% increase) 346.486 → 346.488 → 348.040
✅ docker_agent_jmx_arm64 neutral 329.747 MiB → 332.560
✅ docker_cluster_agent_amd64 neutral 66.459 MiB → 67.220
✅ docker_cluster_agent_arm64 neutral 62.514 MiB → 63.640
✅ docker_cws_instrumentation_amd64 neutral 2.995 MiB → 3.330
✅ docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
✅ docker_dogstatsd_amd64 neutral 14.901 MiB → 15.820
✅ docker_dogstatsd_arm64 neutral 14.233 MiB → 14.830
✅ dogstatsd_deb_amd64 neutral 7.853 MiB → 8.790
✅ dogstatsd_deb_arm64 neutral 6.739 MiB → 7.710
✅ dogstatsd_rpm_amd64 neutral 7.866 MiB → 8.800
✅ dogstatsd_suse_amd64 neutral 7.866 MiB → 8.800
✅ iot_agent_deb_amd64 neutral 11.234 MiB → 12.040
✅ iot_agent_deb_arm64 neutral 9.600 MiB → 10.450
✅ iot_agent_deb_armhf +2.68 KiB (0.03% increase) 9.802 → 9.804 → 10.620
✅ iot_agent_rpm_amd64 neutral 11.251 MiB → 12.060
✅ iot_agent_suse_amd64 neutral 11.251 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Feb 19, 2026 •
edited
Loading

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 70345cd1-4ebd-4989-9617-cbcc83d3b4b4

Baseline: d772b35
Comparison: 207b128
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
➖ docker_containers_cpu % cpu utilization +0.17 [-2.88, +3.23] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ tcp_syslog_to_blackhole ingress throughput +0.70 [+0.60, +0.81] 1 Logs
➖ ddot_metrics memory utilization +0.58 [+0.37, +0.80] 1 Logs
➖ ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.38 [+0.15, +0.62] 1 Logs
➖ file_tree memory utilization +0.35 [+0.30, +0.40] 1 Logs
➖ docker_containers_cpu % cpu utilization +0.17 [-2.88, +3.23] 1 Logs
➖ ddot_metrics_sum_cumulative memory utilization +0.03 [-0.13, +0.18] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput +0.02 [-0.46, +0.50] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.41, +0.44] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.01 [-0.04, +0.07] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.14] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.10, +0.10] 1 Logs
➖ uds_dogstatsd_to_api_v3 ingress throughput -0.02 [-0.14, +0.11] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput -0.04 [-0.42, +0.34] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput -0.04 [-0.09, -0.00] 1 Logs
➖ quality_gate_idle memory utilization -0.05 [-0.09, +0.00] 1 Logs bounds checks dashboard
➖ otlp_ingest_logs memory utilization -0.07 [-0.17, +0.03] 1 Logs
➖ ddot_metrics_sum_delta memory utilization -0.09 [-0.28, +0.10] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.14 [-0.29, +0.02] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.14 [-0.18, -0.10] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization -0.14 [-1.65, +1.37] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization -0.21 [-0.29, -0.14] 1 Logs
➖ quality_gate_metrics_logs memory utilization -0.84 [-1.04, -0.63] 1 Logs bounds checks dashboard
➖ ddot_logs memory utilization -0.91 [-0.97, -0.84] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
✅ docker_containers_cpu simple_check_run 10/10
✅ docker_containers_memory memory_usage 10/10
✅ docker_containers_memory simple_check_run 10/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency lost_bytes 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@Gandem
host-profiler: set cgroup namespace to host in dev docker-compose
8fdd136 
On cgroup v2, Docker keeps private cgroup namespaces even for
privileged containers. This causes /proc/self/cgroup to return 0::/,
which breaks self container ID detection. Setting cgroup: "host"
gives the profiler the host cgroup namespace so it can resolve its
own container tags.
@Gandem
Add profiling-full-host as co-codeowners of cmd/host-profiler
cf7dacb
@Gandem Gandem force-pushed the nayef/host-profiler-cgroupns-host branch from 38639ff to cf7dacb Compare February 19, 2026 09:18
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 5ac107d into main Feb 19, 2026
291 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the nayef/host-profiler-cgroupns-host branch February 19, 2026 20:20
@github-actions github-actions bot added this to the 7.77.0 milestone Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@songy23 songy23 songy23 approved these changes

@nsavoire nsavoire nsavoire approved these changes

@theomagellan theomagellan theomagellan approved these changes

@liustanley liustanley Awaiting requested review from liustanley liustanley is a code owner automatically assigned from DataDog/opentelemetry-agent

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/profiling-full-host

Projects

None yet

Milestone

7.77.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Gandem @songy23 @nsavoire @theomagellan