[Backport 7.76.x] Push to bazel* caches from the main branch only#46179
Conversation
… does this PR do? Configure GitLab `bazel*` caches on ephemeral runners to use a `pull`-only policy by default, and `pull-push` only when running on the `main` branch. This restriction applies only to **GitLab** caches - at this stage, the `bazel` **remote** cache remains indeed shared across all branches. ### Motivation 1. avoid cache pollution from feature and release branches while allowing `main` to populate the cache in a _progressive_ manner, 2. because the GitLab cache is uploaded to a shared S3 bucket, restricting uploads to `main` reduces S3 write contention and costs incurred by parallel cache overwrites. Because the GitLab cache is shared across pipelines, allowing feature or release branches to push artifacts pollutes the cache with _experimental_ entries from feature branches and _meanwhile-evicted_ entries from oldest release branches. ### Additional Notes Release branches and feature branches _behind_ `main` may fetch _older_ dependencies, whereas feature branches _ahead_ of `main` may fetch _newer_ dependencies, but: - they'll still benefit from the `bazel` remote cache, - they'll no longer incur the overhead of uploading GitLab caches. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com> (cherry picked from commit 0463d57) ___ Co-authored-by: Régis Desgroppes <rdesgroppes@gmail.com>
Gitlab CI Configuration ChangesChanges Summary
ℹ️ Diff available in the job log. |
Static quality checks✅ Please find below the results from static quality gates 31 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 188e66f Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.06 | [-2.02, +4.15] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +1.50 | [+1.28, +1.73] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | +1.06 | [-2.02, +4.15] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.65 | [+0.58, +0.72] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.39 | [+0.23, +0.56] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.35 | [+0.13, +0.56] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.34 | [+0.29, +0.39] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.32 | [+0.27, +0.37] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.22 | [+0.16, +0.29] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.18 | [+0.14, +0.22] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | +0.14 | [+0.05, +0.23] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.09 | [-0.30, +0.47] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.05 | [-0.18, +0.29] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.03, +0.05] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.01 | [-0.42, +0.44] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.09, +0.11] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.01 | [-0.24, +0.22] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.12, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.02 | [-0.14, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.47, +0.44] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.21 | [-0.25, -0.17] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | -0.55 | [-0.70, -0.39] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.70 | [-2.18, +0.79] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -3.09 | [-3.19, -2.99] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Backport 0463d57 from #46151.
What does this PR do?
Configure GitLab
bazel*caches on ephemeral runners to use apull-only policy by default, andpull-pushonly when running on themainbranch.This restriction applies only to GitLab caches - at this stage, the
bazelremote cache remains indeed shared across all branches.Motivation
mainto populate the cache in a progressive manner,mainreduces S3 write contention and costs incurred by parallel cache overwrites.Because the GitLab cache is shared across pipelines, allowing feature or release branches to push artifacts pollutes the cache with experimental entries from feature branches and meanwhile-evicted entries from oldest release branches.
Additional Notes
Release branches and feature branches behind
mainmay fetch older dependencies, whereas feature branches ahead ofmainmay fetch newer dependencies, but:bazelremote cache,