[ABLD-300] Also pass `CI` to `docker build` for `bazel` (and others) by rdesgroppes · Pull Request #43672 · DataDog/datadog-agent

rdesgroppes · 2025-12-01T13:29:11Z

What does this PR do?

Following the same approach as PR #43274 which generalized bazel CI configuration for docker run commands, this extends the CI environment variable propagation to docker build contexts, enabling nested bazel invocations to automatically benefit from bazel --config=ci settings (as configured in .bazelrc) and cache detection when applicable.

Motivation

The CI variable is a de facto standard (GitLab CI, GitHub Actions, Travis, CircleCI) already leveraged by other tools including pip, dda, etc.

Using it rather than the custom CIBUILD avoids propagation issues from omitted remapping - tools and scripts that check for CI presence work automatically without requiring explicit variable renaming (e.g., CIBUILD=$CI) at each layer or invocation.

Additional Notes

With --build-arg CI/--build-arg=CI without a value, docker build automatically propagates its value verbatim) from the host environment (if defined) into the container (doc, similar to -e/--env for docker run).

agent-platform-auto-pr · 2025-12-01T13:33:20Z

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed	Modified	Added	Renamed
0	56	0	0

ℹ️ Diff available in the job log.

agent-platform-auto-pr · 2025-12-01T14:59:58Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 2869418

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0}$$	$${705.02}$$ < $${717.44}$$	$${-0.03}$$	$${172.9}$$ < $${177.37}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${699.86}$$ < $${711.66}$$	$${+0.06}$$	$${171.73}$$ < $${174.84}$$
✅	agent_heroku_amd64	$${0}$$	$${326.33}$$ < $${337.57}$$	$${+0.01}$$	$${87.34}$$ < $${90.78}$$
✅	agent_msi	$${0}$$	$${969.05}$$ < $${1015.38}$$	$${0}$$	$${141.39}$$ < $${149.42}$$
✅	agent_rpm_amd64	$${+0}$$	$${705.0}$$ < $${717.41}$$	$${+0.04}$$	$${175.95}$$ < $${178.01}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${699.84}$$ < $${711.64}$$	$${+0}$$	$${173.95}$$ < $${177.26}$$
✅	agent_rpm_arm64	$${-0}$$	$${690.69}$$ < $${702.19}$$	$${+0.02}$$	$${159.74}$$ < $${163.22}$$
✅	agent_rpm_arm64_fips	$${-0}$$	$${686.49}$$ < $${697.6}$$	$${+0.05}$$	$${159.1}$$ < $${162.68}$$
✅	agent_suse_amd64	$${+0}$$	$${705.0}$$ < $${717.41}$$	$${+0.04}$$	$${175.95}$$ < $${178.01}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${699.84}$$ < $${711.64}$$	$${+0}$$	$${173.95}$$ < $${177.26}$$
✅	agent_suse_arm64	$${-0}$$	$${690.69}$$ < $${702.19}$$	$${+0.02}$$	$${159.74}$$ < $${163.22}$$
✅	agent_suse_arm64_fips	$${-0}$$	$${686.49}$$ < $${697.6}$$	$${+0.05}$$	$${159.1}$$ < $${162.68}$$
✅	docker_agent_amd64	$${+0}$$	$${767.35}$$ < $${769.92}$$	$${+0}$$	$${260.59}$$ < $${261.52}$$
✅	docker_agent_arm64	$${-0}$$	$${777.3}$$ < $${779.46}$$	$${-0}$$	$${250.78}$$ < $${251.72}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${958.23}$$ < $${960.8}$$	$${-0}$$	$${329.22}$$ < $${330.15}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${956.9}$$ < $${958.93}$$	$${+0}$$	$${315.4}$$ < $${316.35}$$
✅	docker_cluster_agent_amd64	$${-0}$$	$${178.85}$$ < $${207.49}$$	$${0}$$	$${63.16}$$ < $${70.2}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${196.33}$$ < $${223.38}$$	$${+0}$$	$${59.88}$$ < $${66.42}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.58}$$ < $${39.3}$$	$${-0}$$	$${14.91}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.24}$$ < $${37.94}$$	$${-0}$$	$${14.36}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.8}$$ < $${30.53}$$	$${-0}$$	$${7.86}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.31}$$ < $${29.11}$$	$${-0}$$	$${6.8}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.8}$$ < $${30.53}$$	$${+0}$$	$${7.87}$$ < $${8.76}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.8}$$ < $${30.53}$$	$${+0}$$	$${7.87}$$ < $${8.76}$$
✅	iot_agent_deb_amd64	$${0}$$	$${42.55}$$ < $${43.19}$$	$${+0}$$	$${11.12}$$ < $${11.98}$$
✅	iot_agent_deb_arm64	$${0}$$	$${40.29}$$ < $${40.92}$$	$${-0}$$	$${9.57}$$ < $${10.45}$$
✅	iot_agent_deb_armhf	$${0}$$	$${40.2}$$ < $${40.86}$$	$${+0}$$	$${9.69}$$ < $${10.56}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${42.56}$$ < $${43.19}$$	$${-0}$$	$${11.13}$$ < $${12.0}$$
✅	iot_agent_suse_amd64	$${0}$$	$${42.56}$$ < $${43.19}$$	$${-0}$$	$${11.13}$$ < $${12.0}$$

cit-pr-commenter · 2025-12-01T15:09:33Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c3df2bfc-d450-4666-9ace-6253b6d649b3

Baseline: 2869418
Comparison: 97eea4f
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-2.04	[-4.96, +0.87]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+2.42	[+2.36, +2.48]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+1.65	[+1.43, +1.86]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.63	[+0.49, +0.78]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.35	[+0.30, +0.41]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.33	[+0.09, +0.57]	1	Logs
➖	file_tree	memory utilization	+0.30	[+0.25, +0.35]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.08	[-0.29, +0.45]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.07, +0.08]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.13, +0.12]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.01	[-0.14, +0.13]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.03	[-0.43, +0.38]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.03	[-0.07, +0.02]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.07	[-0.46, +0.33]	1	Logs
➖	docker_containers_memory	memory utilization	-0.12	[-0.20, -0.03]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.15	[-0.30, -0.01]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.20	[-0.30, -0.11]	1	Logs
➖	quality_gate_idle	memory utilization	-0.24	[-0.29, -0.19]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.38	[-0.43, -0.32]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	-0.42	[-0.47, -0.36]	1	Logs
➖	ddot_metrics	memory utilization	-0.63	[-0.83, -0.43]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.72	[-0.93, -0.51]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.33	[-2.76, +0.10]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-2.04	[-4.96, +0.87]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Extend `CI` environment variable propagation to `docker build` contexts, enabling nested `bazel` invocations to automatically benefit from `bazel --config=ci` settings (as configured in `.bazelrc`) and applicable caching. Following the same approach as commit PR #43274 which generalized `bazel` CI configuration for `docker run` commands, this ensures `docker build` operations also detect the CI environment. The `CI` variable is a _de facto_ standard (GitLab CI, GitHub Actions, Travis, CircleCI) already leveraged by existing tools including `pip`, `dda`, etc.. Using the standard `CI` variable rather than a custom name avoids propagation issues from omitted remapping - tools and scripts that check for CI presence work automatically without requiring explicit variable renaming (e.g., `CIBUILD=$CI`) at each layer or invocation. This therefore replaces the custom `CIBUILD` variable with the standard `CI` variable in Dockerfiles, ensuring uniform treatment across all `docker` operations (both `build` and `run` contexts).

rdesgroppes · 2025-12-02T10:28:15Z

/merge

dd-devflow-routing-codex · 2025-12-02T10:28:19Z

View all feedbacks in Devflow UI.

2025-12-02 10:28:18 UTC ℹ️ Start processing command /merge

2025-12-02 10:28:22 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 42m (p90).

2025-12-02 11:39:29 UTC ℹ️ MergeQueue: This merge request was merged

rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Dec 1, 2025

github-actions bot added the medium review PR review might take time label Dec 1, 2025

rdesgroppes changed the title ~~Also pass CI to docker build for bazel CI config~~ Also pass CI to docker build for bazel (and others) Dec 1, 2025

rdesgroppes force-pushed the regis.desgroppes/also-propagate-ci-setup-to-docker-builds branch 2 times, most recently from d6ec9e1 to 76f58d3 Compare December 1, 2025 14:15

rdesgroppes marked this pull request as ready for review December 1, 2025 14:16

rdesgroppes requested review from a team as code owners December 1, 2025 14:16

rdesgroppes requested a review from RiantZ December 1, 2025 14:16

julien-lebot approved these changes Dec 1, 2025

View reviewed changes

rdesgroppes added the ask-review Ask required teams to review this PR label Dec 1, 2025

lavigne958 approved these changes Dec 1, 2025

View reviewed changes

RiantZ approved these changes Dec 1, 2025

View reviewed changes

rdesgroppes force-pushed the regis.desgroppes/also-propagate-ci-setup-to-docker-builds branch from 76f58d3 to 97eea4f Compare December 1, 2025 23:46

chouetz approved these changes Dec 2, 2025

View reviewed changes

alopezz approved these changes Dec 2, 2025

View reviewed changes

rdesgroppes changed the title ~~Also pass CI to docker build for bazel (and others)~~ [ABLD-300] Also pass CI to docker build for bazel (and others) Dec 2, 2025

dd-mergequeue bot merged commit 242de6c into main Dec 2, 2025
347 checks passed

dd-mergequeue bot deleted the regis.desgroppes/also-propagate-ci-setup-to-docker-builds branch December 2, 2025 11:39

github-actions bot added this to the 7.75.0 milestone Dec 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ABLD-300] Also pass `CI` to `docker build` for `bazel` (and others)#43672

[ABLD-300] Also pass `CI` to `docker build` for `bazel` (and others)#43672
dd-mergequeue[bot] merged 1 commit intomainfrom
regis.desgroppes/also-propagate-ci-setup-to-docker-builds

rdesgroppes commented Dec 1, 2025 •

edited

Loading

Uh oh!

agent-platform-auto-pr bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

agent-platform-auto-pr bot commented Dec 1, 2025 •

edited

Loading

Info

Uh oh!

cit-pr-commenter bot commented Dec 1, 2025 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

rdesgroppes commented Dec 2, 2025

Uh oh!

dd-devflow-routing-codex bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

rdesgroppes commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Uh oh!

agent-platform-auto-pr bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Gitlab CI Configuration Changes

Changes Summary

Uh oh!

agent-platform-auto-pr bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

cit-pr-commenter bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

rdesgroppes commented Dec 2, 2025

Uh oh!

dd-devflow-routing-codex bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rdesgroppes commented Dec 1, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Dec 1, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Dec 1, 2025 •

edited

Loading

cit-pr-commenter bot commented Dec 1, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Dec 2, 2025 •

edited

Loading