Merged
Conversation
luphaz
commented
Apr 20, 2023
| var NoSideEffectDisruptions = map[chaostypes.DisruptionKindName]struct{}{ | ||
| chaostypes.DisruptionKindNodeFailure: {}, | ||
| chaostypes.DisruptionKindContainerFailure: {}, | ||
| chaostypes.DisruptionKindCPUPressure: {}, |
Contributor
Author
There was a problem hiding this comment.
We now move several processes to other CGroups, even if we put great care to kill them if anything is going wrong, we are not exempt from bug, hence we might have a side effect.
luphaz
commented
Apr 20, 2023
cgroup/cgroup_linux.go
Outdated
| return strings.TrimSuffix(content, "\n"), nil | ||
| } | ||
|
|
||
| func (cg cgroup) ReadCPUSet() (cpuset.CPUSet, error) { |
Contributor
Author
There was a problem hiding this comment.
It's way more easier to have this here than in the caller, feels to me it's cgroup package responsibility to know such things
5511ee5 to
ff7ec0e
Compare
7075380 to
8bb53be
Compare
ff7ec0e to
51825bf
Compare
Base automatically changed from
matthieu.bono/CHAOS-503/upgrade-gingko-v2
to
main
April 20, 2023 13:54
3f300f3 to
d609ed5
Compare
06afd0a to
1aea2d7
Compare
ptnapoleon
reviewed
Apr 20, 2023
ptnapoleon
reviewed
Apr 20, 2023
ptnapoleon
reviewed
Apr 20, 2023
ptnapoleon
reviewed
Apr 20, 2023
ptnapoleon
reviewed
Apr 20, 2023
ptnapoleon
reviewed
Apr 20, 2023
ptnapoleon
reviewed
Apr 20, 2023
ptnapoleon
reviewed
Apr 20, 2023
e8f50d3 to
79bfb04
Compare
f933ca0 to
b4ee22d
Compare
taihuynh167
approved these changes
Apr 21, 2023
6fa29d4 to
5560eed
Compare
clairecng
reviewed
May 17, 2023
clairecng
reviewed
May 17, 2023
9a2f5b0 to
d90d0e3
Compare
558e712 to
b2c1981
Compare
Datadog ReportBranch report: ✅ |
b2c1981 to
b65d56f
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Please briefly describe your changes as well as the motivation behind them:
cpu-pressureinjector to be able to react to container restartsPreviouslyInjectedstatus (when it was partially injected or not injected, an expired disruption changed to the same status, it's no longer the case)previouslyinjection status is calculated to ensure when injection pods exited successfully near the deadline we are not transitioning back toPartiallyInjectedThis PR also takes the opportunity to (re)-introduce a
make localrule to run the controller outside of Kubernetes.This PR also introduce a
make pre-debugthat will likemake localexcept it won't launch the binary and will let you use you favorite debugger method (IDE, dlv, ...)This PR also review how we are running e2e-test to guarantee pods are created for each test ran and ease their duplication.
E2E-tests are hence now ran in parallel.
Code Quality Checklist
Testing
unittests orend-to-endtests.unittests orend-to-endtests.