Skip to content

Implement lock mechanism#230

Merged
Mikescops merged 1 commit intomasterfrom
feature/lock-mechanism
Mar 29, 2024
Merged

Implement lock mechanism#230
Mikescops merged 1 commit intomasterfrom
feature/lock-mechanism

Conversation

@Mikescops
Copy link
Contributor

When using the keychains, it's possible to run commands indefinitely unless you lock your keychain.
I'm adding a sub-mechanism to drop the key in keychain so it forces to re-ask for the master password on the next command.

For the ones more concerned about using the keychain:

  • you have a configuration available to not store your master password in the keychain
  • you can create a cron job or a script that locks your vault at a given period of time or by an action

@Mikescops Mikescops added the features New feature or request label Mar 29, 2024
@Mikescops Mikescops requested review from jboillot and showi March 29, 2024 13:03
@Mikescops Mikescops self-assigned this Mar 29, 2024
@Mikescops Mikescops merged commit e16b137 into master Mar 29, 2024
@Mikescops Mikescops deleted the feature/lock-mechanism branch March 29, 2024 14:16
@jboillot
Copy link
Contributor

In my opinion, these lock mechanisms should rather be managed directly by the keychain, but I understand it is temporarily simpler like that, and easier to find and understand than dcli configure save-master-password false && dcli configure save-master-password true that has the same semantics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

features New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants