Fix Razer keyboard LED mappings#254
Merged
DarthAffe merged 4 commits intoDarthAffe:Developmentfrom Feb 22, 2022
Merged
Conversation
DarthAffe
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #253.
According to Razer's official documentation found here, Razer keyboards use a single mapping layout for all keyboard devices, regardless of if keys exist on the physical device or not.
RGB.NET has implemented multiple definitions to match with the physical layout of different types of keyboards (normal, laptop and blackwidow) which is actually offsets the keys on these devices, due to them all using the same layout. This PR removes those extra definitions and keeps the standard definition, which should work for all Razer keyboards.
I have tested this PR on the following types of Razer devices and confirmed this works:
Note: sorry for the double commit of LedMappings.cs, I accidently wrote RazerDeviceProvider.cs over it, so needed to revert it.