Fix race condition in TimerUpdateTrigger stop#231
Merged
RobertBeekman merged 1 commit intoDevelopmentfrom Sep 3, 2021
Merged
Conversation
DarthAffe
approved these changes
Sep 3, 2021
Owner
DarthAffe
left a comment
There was a problem hiding this comment.
Not sure if i'm a fan if ignoring only the AggregateException here - but for now it's fine - i'll think about that later
Collaborator
Author
|
I did try to look for a more official way to catch this but couldn't find any (though I didn't look for more than 15 mins or so) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Stop()waits for the task to finish but if it's already cancelled when it starts waiting it throws a TaskCancelledExceptionThis is a race condition and depending on how long the task takes to cancel it either occurs or it doesn't.