Skip to content

G733 Headset fix#221

Merged
DarthAffe merged 2 commits intoDarthAffe:Developmentfrom
piechade:Logitech
Jun 3, 2021
Merged

G733 Headset fix#221
DarthAffe merged 2 commits intoDarthAffe:Developmentfrom
piechade:Logitech

Conversation

@piechade
Copy link

@piechade piechade commented Jun 3, 2021

Sorry about the new pull request, I commit some other changes that I'm using to fix Asus provider.

@piechade
Copy link
Author

piechade commented Jun 3, 2021

I defined G733 as both types to test it.

        public static HIDLoader<int, (LogitechDeviceType deviceType, int zones)> PerZoneDeviceDefinitions { get; } = new(VENDOR_ID)
        {
            { 0xAB5, RGBDeviceType.Headset, "G733", LedMappings.ZoneHeadset, (LogitechDeviceType.Headset, 2) },
        };

        public static HIDLoader<int, int> PerDeviceDeviceDefinitions { get; } = new(VENDOR_ID)
        {
            { 0xAB5, RGBDeviceType.Headset, "G733 2", LedMappings.Device, 0 },
        };

Artemis UI_mEZheG9gbJ

<?xml version="1.0" encoding="utf-8"?>
<Device xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <Name>Logitech G733</Name>
  <Description>Layout of the G733 Headset</Description>
  <Author>Dennis Piecha</Author>
  <Type>Headset</Type>
  <Vendor>Logitech</Vendor>
  <Model>G733</Model>
  <Width>266</Width>
  <Height>200</Height>
  <Leds>
    <Led Id="Headset1" />
    <Led Id="Headset2" />
  </Leds>
  <CustomData>
    <DeviceImage>G733.png</DeviceImage>
  </CustomData>
</Device>

The one zone device is blinking and the per zone device not.

@DarthAffe DarthAffe merged commit 790f552 into DarthAffe:Development Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants