Skip to content

Asus Keyboard Support#101

Merged
DarthAffe merged 1 commit intoDarthAffe:asuskeyboardfrom
xQwexx:fix/asus-keyboard
Feb 15, 2020
Merged

Asus Keyboard Support#101
DarthAffe merged 1 commit intoDarthAffe:asuskeyboardfrom
xQwexx:fix/asus-keyboard

Conversation

@xQwexx
Copy link
Contributor

@xQwexx xQwexx commented Dec 28, 2019

Support Asus strix scope (tested), Asus strix flare (not tested)
Claymore (not implemented)

Asus strix scope tested
Asus strix flare not tested

Signed-off-by: Alex <ritt.alex@gmail.com>
{
IAuraRgbLight light;
//UK keyboard Layout
if (index == 0x56)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, could you add some information what all these magic numbers come from and what exactly they mean?

@xQwexx
Copy link
Contributor Author

xQwexx commented Dec 29, 2019

Which specific numbers? Generally I found the numbers in the Asus sdk description (developer tutorial) but it is just worked with the us layout so I needed to map the backslash and the hashtag key to work with uk layout.

@DarthAffe DarthAffe changed the base branch from Development to asuskeyboard February 15, 2020 11:34
@DarthAffe DarthAffe merged commit 74da1bb into DarthAffe:asuskeyboard Feb 15, 2020
@xQwexx xQwexx deleted the fix/asus-keyboard branch May 14, 2020 22:47
@RobertBeekman
Copy link
Collaborator

@xQwexx Someone that's trying to use the Asus Strix Flare with Artemis is having some issues. Would you be able to take a look?

Frittata_di_Maccheron on Discord:

Keyboard_LeftGui is mapped in editor, shows in debugger, but doesn't light up (it actually lights up LeftAlt even though it's mapped correctly in Layout editor)
Keyboard_RightGui is mapped in editor, doesn't show in debugger, there is no "Keyboard_RightGui" even listed in debugger
Keyboard_Custom36 doesn't show in LayoutEditor, but is listed only in debugger but is not mapped or colored
also LeftGui and RightGui leds either light up together with a wrong color on Artemis startup or just don't turn on

image
i also added a picture from the keyboard, Win and Fn keys appear yellow, but should be the same color as surrounding keys
image

Feel free to join us at https://discord.com/invite/S3MVaC9 :)

@xQwexx
Copy link
Contributor Author

xQwexx commented Nov 26, 2020

@SpoinkyNL
So I think I know the cause of this problem, When I wrote this pr I didn't know that the flare and scope are also the same 'Charm' name in the API, so I made following changes what is intended for the scope layout

	                            // Asus Strix Scope
                            if (keyboard.Name == "Charm")
                            {
                                if (index == 0XDB)
                                {
                                    light = keyboard.Lights[(int)(5 * keyboard.Width + 2)];
                                }
                                else if (index == 0x38)
                                {
                                    light = keyboard.Lights[(int)(5 * keyboard.Width + 3)];
                                }
                            }

What is going to be wrong in the flare layout, but because I don't own a flare I couldn't test it.
The problem that it is impossible decide which device are detected from the asus sdk itself :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants