Fix test tracking when ranges are deleted #5834
Merged
+42
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing changes, we were firing the callbacks in-line while enumerating the trackers. A deleted position could result in a tracked range from disposing itself (the start position is deleted first, and it then disposes and untracks the end position) which modified the list of trackers while we were enumerating. To fix, we store up the callbacks so nothing is modified while we synchronously process the changes. Fixes #5831
Member
Author
|
@codex review /gemini review |
|
I've received your request for a code review via |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing changes, we were firing the callbacks in-line while enumerating the trackers. A deleted position could result in a tracked range from disposing itself (the start position is deleted first, and it then disposes and untracks the end position) which modified the list of trackers while we were enumerating.
To fix, we store up the callbacks so nothing is modified while we synchronously process the changes.
Fixes #5831