-
Notifications
You must be signed in to change notification settings - Fork 340
Add support for DevTools-server-driven extension recommendations #4847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI @vlidholt. |
3ce3068 to
568e8ae
Compare
568e8ae to
2926a39
Compare
Allow turning extension recommendations on/off, custom allow list, and show progress when installing extensions.
54ab25a to
e0ec68a
Compare
|
I've added some tests and some settings so user can a) turn extension recommendations off entirely and b) replace the allow-list so that authors of packages/extensions could verify their This is essentially ready to merge (with an empty allow-list), but due to the recent issues with paths, I think we should gate it on an SDK that has @kenzieschmoll how is that version bumped in DDS? Is it coming direct from Pub and not via DEPS in the SDK? Do you already have a plan for when to increase it there? If we're not ready yet, I could merge this with a very high SDK version and we can move it down once we know which Dart SDK we're happy for it to start being used for. |
I rolled the latest DevTools into the Dart SDK yesterday (including your post message fix for the flutter sidebar). And since the DDS dep on devtools_shared is |
|
I was a bit concerned by not having 6.0.3 in the pubspec to enforce this, but I see you've landed dart-lang/sdk@a86eb8b now so looks like it's safe to use 3.3.0-247 - thanks! |
Adds support for asking DevTools server for any VS Code extension recommendations (which are ready from packages that your workspace depends on).
Fixes #4705