Skip to content

Conversation

@DanTup
Copy link
Member

@DanTup DanTup commented Nov 20, 2023

Adds support for asking DevTools server for any VS Code extension recommendations (which are ready from packages that your workspace depends on).

  • Needs tests
  • Needs SDK work to land
  • Need to verify version number in capabilities
  • Need to confirm exact text(/disclaimer?)
  • Needs an initial whitelist as part of rollout (empty, can add to later)

image

image

Fixes #4705

@DanTup DanTup added is enhancement in devtools Relates to integration with Dart/Flutter DevTools labels Nov 20, 2023
@DanTup DanTup added this to the v3.78.0 milestone Nov 20, 2023
@DanTup DanTup modified the milestones: v3.78.0, v3.80.0 Nov 27, 2023
@kenzieschmoll
Copy link

FYI @vlidholt.

@DanTup DanTup force-pushed the extension-recommendations branch 2 times, most recently from 3ce3068 to 568e8ae Compare December 6, 2023 17:57
@DanTup DanTup force-pushed the extension-recommendations branch from 568e8ae to 2926a39 Compare December 18, 2023 12:59
Allow turning extension recommendations on/off, custom allow list, and show progress when installing extensions.
@DanTup DanTup force-pushed the extension-recommendations branch from 54ab25a to e0ec68a Compare December 18, 2023 16:13
@DanTup
Copy link
Member Author

DanTup commented Dec 18, 2023

I've added some tests and some settings so user can a) turn extension recommendations off entirely and b) replace the allow-list so that authors of packages/extensions could verify their extension/vs_code config locally before being in the list.

This is essentially ready to merge (with an empty allow-list), but due to the recent issues with paths, I think we should gate it on an SDK that has devtools_shared v6.0.3 that has the fixes.

@kenzieschmoll how is that version bumped in DDS? Is it coming direct from Pub and not via DEPS in the SDK? Do you already have a plan for when to increase it there?

If we're not ready yet, I could merge this with a very high SDK version and we can move it down once we know which Dart SDK we're happy for it to start being used for.

@kenzieschmoll
Copy link

This is essentially ready to merge (with an empty allow-list), but due to the recent issues with paths, I think we should gate it on an SDK that has devtools_shared v6.0.3 that has the fixes. How is that version bumped in DDS? Is it coming direct from Pub and not via DEPS in the SDK? Do you already have a plan for when to increase it there?

I rolled the latest DevTools into the Dart SDK yesterday (including your post message fix for the flutter sidebar). And since the DDS dep on devtools_shared is ^6.0.0, it should already be picking up 6.0.3.

@DanTup
Copy link
Member Author

DanTup commented Dec 20, 2023

I was a bit concerned by not having 6.0.3 in the pubspec to enforce this, but I see you've landed dart-lang/sdk@a86eb8b now so looks like it's safe to use 3.3.0-247 - thanks!

@DanTup DanTup merged commit 643186a into master Dec 20, 2023
@DanTup DanTup deleted the extension-recommendations branch December 20, 2023 14:13
@DanTup DanTup modified the milestones: v3.80.0, v3.82.0 Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in devtools Relates to integration with Dart/Flutter DevTools is enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add logic for VS code to promote other VS code extensions

3 participants