Use instance fields #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
devoncarew
commented
Aug 7, 2016
- move module globals to fields
- tweak no sdk installed error message
- prefer double quotes
| constructor(analyzer: Analyzer) { | ||
| statusBarItem = window.createStatusBarItem(); | ||
| statusBarItem.text = 'Analyzing…'; | ||
| super(() => this.statusBarItem.dispose()); |
Member
There was a problem hiding this comment.
Heh; I put this further down thinking the reference wouldn't exist till I'd created it but of course it's not called untill later so that make no sense!
Member
|
I think it's worth tweaking the message to not suggest the path needs configuring (if we spent effort making it less work for the user, no point telling them to do the extra work) but otherwise this all looks great 👍 |
Contributor
Author
|
updated :) ptal |
Member
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.