Support running tests outside of main function from CodeLenses
#5811
Conversation
|
@codex review |
|
Hello @DanTup! I noticed you used |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds support for running tests defined outside of the main function from CodeLenses. The changes involve modifying the TestOutlineVisitor to track whether it's inside a top-level main function and adjusting the test name regex generation to not anchor to the start for tests outside main. A new test case is added to verify this functionality. The implementation is solid, but I found one potential issue where the check for the main function could be more specific to avoid matching other top-level elements with the same name.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Fixes #5707