Skip to content

Conversation

@DanTup
Copy link
Member

@DanTup DanTup commented Oct 17, 2025

@DanTup DanTup added this to the v3.124.0 milestone Oct 17, 2025
@DanTup DanTup added is enhancement in editor Relates to code editing or language features is performance labels Oct 17, 2025
@DanTup DanTup requested a review from Copilot October 17, 2025 09:40
@DanTup

This comment was marked as resolved.

@gemini-code-assist

This comment was marked as off-topic.

This comment was marked as resolved.

@chatgpt-codex-connector

This comment was marked as resolved.

@DanTup DanTup force-pushed the warn-about-onlyAnalyzeProjectsWithOpenFiles branch from 3364983 to 29cd824 Compare November 11, 2025 16:23
@DanTup
Copy link
Member Author

DanTup commented Nov 11, 2025

@bwilkerson @jwren any opinions on the text for this notification? (it would be shown only to users with the setting enabled, and once they click the button to open the issue or dismiss the notification, we would not show it again).

Image

The button opens dart-lang/sdk#61742 which has some details about why I think we should deprecate this (TL;DR, it makes initial analysis faster, but can cause long delays as we reset analysis roots as the first/last file in any project is opened/closed during normal use).

@bwilkerson
Copy link

That message looks good to me.

If I were going to change anything I might suggest removing "you think", just because I don't think it adds to the meaning, but I'm also fine with leaving it in.

@DanTup DanTup force-pushed the warn-about-onlyAnalyzeProjectsWithOpenFiles branch from 29cd824 to 221c354 Compare November 12, 2025 10:49
@DanTup
Copy link
Member Author

DanTup commented Nov 12, 2025

If I were going to change anything I might suggest removing "you think"

Yep, I agree - done. Thanks!

@DanTup DanTup merged commit 370545d into master Nov 12, 2025
16 checks passed
@DanTup DanTup deleted the warn-about-onlyAnalyzeProjectsWithOpenFiles branch November 12, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in editor Relates to code editing or language features is enhancement is performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants