Support "Add to PATH" for macOS + fix "missing SDK" prompt immediately after installing #5710
Conversation
|
It looks like you're trying to request a code review! To do so, please use either Also, please note that |
There was a problem hiding this comment.
Pull Request Overview
This PR adds macOS support for automatically adding the SDK to PATH and fixes an issue where users were prompted about a missing SDK immediately after successful installation. The fix includes breaking out of the installation loop after successful SDK cloning and implementing platform-specific PATH modification for macOS.
- Add automatic PATH modification support for macOS by detecting shell profiles (.bash_profile for bash, .zshenv for zsh)
- Fix infinite loop issue where users were re-prompted about missing SDK after successful installation
- Update platform detection logic to include macOS alongside existing Windows support
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/extension/sdk/utils.ts | Adds labeled break to exit installation loop after successful SDK clone |
| src/extension/commands/add_sdk_to_path.ts | Implements macOS PATH modification with shell profile detection and file writing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/gemini review |
|
I've received your request for a code review via Just a friendly reminder that |
|
Codex Review: Didn't find any major issues. Hooray! About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
|
@gemini-code-assist I'm assuming you went for lunch and am merging this anyway 😄 |
|
Thanks for the update, DanTup! I understand. Happy to see the progress! 😄 |
No description provided.