Skip to content

Support updating the theme in embedded DevTools #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DanTup merged 1 commit into from
Oct 28, 2024
Merged

Support updating the theme in embedded DevTools #5297

DanTup merged 1 commit into from
Oct 28, 2024

Conversation

@DanTup
Copy link
Member

@DanTup DanTup commented Oct 2, 2024 •
edited
Loading

  • Land when it's clear the DevTools changes will be in the next release, since removal of the refresh does mean that older SDKs will lose the sidebar refreshing (this is minor enough that I don't think it's worth additional conditional code to javascript that is embedded inside a string inside typescript, something that is a pain to debug)/

This requires an equiv DevTools change to land before it'll work (this can ship, it just won't work until DevTools is listening for the postMessage events).

devtools_color_theme_update.mp4
  • update sidebar to use the same mechanism
  • remove hashes from colors in URLs to workaround Flutter issue
  • remove some unused variables

The corresponding DevTools work is at flutter/devtools#8387.

Fixes #4971

@DanTup DanTup added is enhancement in devtools Relates to integration with Dart/Flutter DevTools labels Oct 2, 2024
@DanTup DanTup added this to the v3.100.0 milestone Oct 2, 2024
DanTup added a commit to DanTup/devtools that referenced this pull request Oct 2, 2024
@DanTup
Accept themeChanged events via postMessage as well as DTD
ebc0f6c 
This extracts the code that updates the theme (to `_updateTheme`) and then calls it in response to either a DTD event or a postMessage event.

Fixes Dart-Code/Dart-Code#5297
This was referenced Oct 2, 2024
Merged
Closed
@DanTup DanTup force-pushed the devtools-theme-update branch from 570ead5 to 57ab7a1 Compare October 14, 2024 10:25
@DanTup
Support updating the theme in embedded DevTools
b6dfbae 
+ update sidebar to use the same mechanism
+ remove hashes from colors in URLs to workaround Flutter issue
+ remove some unused variables

Fixes #4971
@DanTup
Copy link
Member Author

DanTup commented Oct 28, 2024

Verified on current Flutter beta.

theme.mp4

@DanTup DanTup force-pushed the devtools-theme-update branch from 57ab7a1 to b6dfbae Compare October 28, 2024 13:05
@DanTup DanTup merged commit 24cc859 into master Oct 28, 2024
@DanTup DanTup deleted the devtools-theme-update branch October 28, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in devtools Relates to integration with Dart/Flutter DevTools is enhancement

Projects

None yet

Milestone

v3.100.0

Development

Successfully merging this pull request may close these issues.

VS Code theme changes do not apply to embedded DevTools until the window is reloaded/recreated

2 participants

@DanTup