Skip to content

Using ${name} in a folder of a log name results in "${name}" folders being created #5184

@DanTup

Description

@DanTup

If I set my logs as below, I see a folder called "${name}" created.

This is because we trigger creation of the folder before the debug session name is inserted.

{
	"dart.dapLogFile": "C:\\logs\\${workspaceName}\\dapLogFile.txt",
	"dart.analyzerLogFile": "C:\\logs\\${workspaceName}\\analyzerLogFile.txt",
	"dart.dartTestLogFile": "C:\\logs\\${workspaceName}\\${name}\\dartTestLogFile.txt",
	"dart.extensionLogFile": "C:\\logs\\${workspaceName}\\extensionLogFile.txt",
	"dart.devToolsLogFile": "C:\\logs\\${workspaceName}\\devToolsLogFile.txt",
	"dart.vmServiceLogFile": "C:\\logs\\${workspaceName}\\${name}\\vmServiceLogFile.txt",
	"dart.webDaemonLogFile": "C:\\logs\\${workspaceName}\\${name}\\webDaemonLogFile.txt",
	"dart.flutterRunLogFile": "C:\\logs\\${workspaceName}\\${name}\\flutterRunLogFile.txt",
	"dart.flutterTestLogFile": "C:\\logs\\${workspaceName}\\${name}\\flutterTestLogFile.txt",
	"dart.flutterDaemonLogFile": "C:\\logs\\${workspaceName}\\flutterDaemonLogFile.txt",
	"dart.toolingDaemonLogFile": "C:\\logs\\${workspaceName}\\toolingDaemonLogFile.txt",
	"dart.analyzerInstrumentationLogFile": "C:\\logs\\${workspaceName}\\analyzerInstrumentationLogFile.txt",
}

It's also not clear that some of these logs are legacy (for ex. flutter test) because those things are now wrapped up inside DAP and not executed directly by the extension. Those settings should be moved to the archived section.

(reported by @FMorschel on Discord)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions