Add listener for copy events above the devtools frame #4814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM, thanks! |
Member
|
I've invited you to Dart-Code, feel free to merge this when you're ready. |
auto-submit bot
pushed a commit
to flutter/devtools
that referenced
this pull request
Oct 31, 2023
 Adds a fallback behaviour for copying which will allow copy buttons to actually work in VSCode. NOTE: success toasts will no longer show in VSCode though. I've also added some logging just in case a user is looking at their console when a copy fails. Hopefully this provides enough information that the unhide-able error doesn't look suspicious.  Related to Dart-Code/Dart-Code#4814 Fixes #5775
kenzieschmoll
pushed a commit
to flutter/devtools
that referenced
this pull request
Nov 16, 2023
 Adds a fallback behaviour for copying which will allow copy buttons to actually work in VSCode. NOTE: success toasts will no longer show in VSCode though. I've also added some logging just in case a user is looking at their console when a copy fails. Hopefully this provides enough information that the unhide-able error doesn't look suspicious.  Related to Dart-Code/Dart-Code#4814 Fixes #5775
kenzieschmoll
pushed a commit
to flutter/devtools
that referenced
this pull request
Nov 17, 2023
 Adds a fallback behaviour for copying which will allow copy buttons to actually work in VSCode. NOTE: success toasts will no longer show in VSCode though. I've also added some logging just in case a user is looking at their console when a copy fails. Hopefully this provides enough information that the unhide-able error doesn't look suspicious.  Related to Dart-Code/Dart-Code#4814 Fixes #5775 Mirror package:web version from Flutter SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to overcome a bug with VSCode that isn't allowing Devtools to use the copy api.
I've added the allow permissions to the iframe so that if VSCode ever fixes this issue, we should be able to just start utilizing the original copy method right away :)
The complementary code from Devtools can be found in this PR: flutter/devtools#6598