Skip to content

SDK DAP calls setLibraryDebuggable much more than necessary #4464

@DanTup

Description

@DanTup

There are two issues:

  1. We always call setLibraryDebuggable regardless of whether the current value matches what the default would be
  2. We always call setLibraryDebuggable for every library in an isolate after a Hot Reload, even though the values would stick

We should only send them if they are both a) libraries we haven't already sent values for and b) differ from what the default would be.

We need to ensure these changes don't interfere with when the user changes the settings (applyDebugOptions) which should always re-send all, or we should track the values on the VM side and then only send if they've changed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    in debuggingRelates to the debug adapter or process of running debug sessionsis bugis performancerelies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions