Tried to create a private send method inside TelemetrySender but the compiler complained.

Odd. I tested it here and this seemed ok:

class Foo implements TelemetrySender {
	public sendEventData(eventName: string, data?: Record<string, any> | undefined): void {
		throw new Error("Method not implemented.");
	}
	public sendErrorData(error: Error, data?: Record<string, any> | undefined): void {
		throw new Error("Method not implemented.");
	}

	private foo() {

	}

}

const sender = new Foo();
const logger = env.createTelemetryLogger(sender);

If you have issues though, let me know (although it's probably not important now if we just put the sending in sendEventData for now).

I actually think not logging errors is not a bad idea, but if we ever need them, we'll need to think about this issue, or just add an additional event type for errors.

Yeah, this can be something to consider for later. Right now we're not really capturing them so we shouldn't hold up migrating to the new APIs to change that.

Switch to VS Code's telemetry classes #4377

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions