Skip to content

Improve performance of opening/running test files with lots of tests #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DanTup merged 8 commits into from
Jan 4, 2023
Merged

Improve performance of opening/running test files with lots of tests #4328

DanTup merged 8 commits into from
Jan 4, 2023

Conversation

@DanTup
Copy link
Member

@DanTup DanTup commented Jan 3, 2023 •
edited
Loading

Fixes #4325.
Fixes #4326.

DanTup added 5 commits January 3, 2023 15:47
@DanTup
Avoid rebuilding more of test tree/model than necessary
56b7dd1 
Remove the statuses maintained on each node (which require rebuilding lots of nodes), plus store tests/groups indexed by names to reduce lookups.

See #4325.
See #4326.
@DanTup
Prevent rebuilding of group parents
6ca7f8c
@DanTup
Add new test to expectations
d9acf62
@DanTup
Avoid some recursive tree rebuilds when updating test nodes
0d8f29f
@DanTup
Fix expected test order
152c9ac
@DanTup DanTup added in testing Relates to test execution of Dart/Flutter tests for end users is performance labels Jan 3, 2023
@DanTup DanTup added this to the v3.58.0 milestone Jan 3, 2023
@DanTup DanTup mentioned this pull request Jan 3, 2023
Closed
@DanTup DanTup merged commit 52041b9 into master Jan 4, 2023
@DanTup DanTup deleted the fix-test-performance branch January 4, 2023 12:52
@DanTup DanTup mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in testing Relates to test execution of Dart/Flutter tests for end users is performance

Projects

None yet

Milestone

v3.58.0

Development

Successfully merging this pull request may close these issues.

"Unresponsive extension host" opening large project very slow test execution when there are many (~thousands) of tests defined in a file

2 participants

@DanTup