Skip to content

Output pane auto-focused on workspace/executeCommand failures #3946

@ronba

Description

@ronba

Describe the bug
The VSCode output pane is focused automatically whenever workspace/executeCommand fails.
This is similar to #2280.

To Reproduce
Steps to reproduce the behavior:

  1. Move the Output pane to the sidebar or anywhere else where it is out of focus and switch to a different tab.
  2. Create a dart file with an error that would trigger the 'Go to output' notification. For example, this content would work:
class SomeClass {
}
}
  1. Now when saving the file a dialog like the below should pop up.
    image

At the same time the output pane automatically gets focused - without pressing "Go to output".

Expected behavior
The output pane should only become focused if 'Go to output' is clicked.

Analysis
Looking at the code bundled with the Dart-Code extension - I think the reason is the following change: microsoft/vscode-languageserver-node@a1d9d1a which was made available in version 8 of the language client (while it looks like the extension is still using 7?

Workaround
For now I've just been patching the Dart-Code extension manually :)

Please complete the following information:

  • Dart extension version: v3.39.20220411
  • Dart/Flutter SDK version: 2.10.5

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis bug

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions