-
Notifications
You must be signed in to change notification settings - Fork 340
Switch to VS Code test runner by default + many fixes/improvements #3574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #3572, moves some complexity of "phantom groups" and "loading tests" into the package:test adapter (coordinator). It likely introduces issues with dynamic test names that need fixing.
This will simplify things for dynamic tests that will become containers.
…ldren when building tree
…esults more reliable
…e times This could happen using the gutter icons which would send a dynamic test + a node for each of its real test instances, which we'd previously run in a loop. These are now combined into a single regex that includes them all (but won't cause multiple runs).
…ests better This should be more reliable when looking up nodes by their ID when there are concurrent runs happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: