Exclude .dart_tool folder from upgrade packages list #3014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the `.dart_tool` folder from appearing within the **Flutter: Upgrade Packages** list. Fixes #3013.
DanTup
reviewed
Dec 16, 2020
src/shared/utils/fs.ts
Outdated
| const projectFoldersChecks = await Promise.all(projectFolderPromises); | ||
| const projectFolders = projectFoldersChecks | ||
| .filter((res) => res.exists) | ||
| .filter((res) => res.exists && !res.folder.includes(".dart_tool")) |
Member
There was a problem hiding this comment.
We should probably more this to the filter on line 94 (or an additional line next to it) to avoid the hasPubspec etc. checks on folders we'd then discard anyway.
We should also probably also put ${path.sep} on each end just to ensure we only get folders with exactly that segment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the
.dart_toolfolder from appearing within the Flutter: Upgrade Packages list.Fixes #3013.