Skip to content

Use VM Service getStack() limit argument to speed up fetching stacks on web #2933

@DanTup

Description

@DanTup

Computing the call stack on web can be slow, and we have to do the entire thing even when VS Code only wants the top 20 frames.

The VM service is getting support for fetching a slice:

dart-lang/sdk@89de1e8

And I found that if we just give VS Code a totalFrames or requestedFrames + batchSize, it will happily call us multiple times with batches (this is not spec'd behaviour, but it seems worth the trade-off of possibly having to revert/update in future).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions