Skip to content

Incorrect override code generated when choices contain commas #2813

@DanTup

Description

@DanTup

Originally raised at dart-lang/sdk#43460 by @jensjoha.

"Create missing overrides" when using DAS creates bad code here:

abstract class Foo<E, F> {
  E hello(Foo<E, F> x);
}

class Bar implements Foo<String, String> {
}

The cause is commas in the choices:

[12:44:34 PM] [General] [Info] Calling insertSnippet with:
${1|Foo<String, String>,Object|} ${2:x}

These should be escaped somewhere.

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis bug

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions