Tweaks to Flutter initialization #2743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f4f944 to
ec84a79
Compare
ec84a79 to
225b4a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Flutter is missing the
versionfile orbin/cache/dart-sdk, this will show an "initializing..." notification (same as Snap support already did) and delay activation until that's done. This prevents some weird edge cases (including #2638) where we might initialize badly.@MarcusTomlinson this shouldn't change anything for snap (and the CI tests still pass), it's mostly just making some of its code reusable - but FYI! (I'll likely make a beta build including this in the next few days).