Skip to content

Capture Logs command doesn't capturing Observatory logs intermittently #1545

@DanTup

Description

@DanTup

Noticed that periodically, Observatory logs were not being logged to the Capture Logs command output. Turns out we were comparing Sessions by objects, and sometimes these would be different. In that case, the ID was always the same (and we should've probably used this in the first place).

Most likely this is an async race, maybe related to the same issue in the last VS Code release:

https://github.com/Microsoft/vscode/blob/ac46ca2a5e5aaab3f01cffec46d3e2ac96519f1f/src/vs/workbench/api/node/extHostDebugService.ts#L798

Metadata

Metadata

Assignees

No one assigned

    Labels

    in commandsRelates to commands (usually invoked from the command Palette)in debuggingRelates to the debug adapter or process of running debug sessionsis bug

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions