Skip to content

Read snippets from Flutter if supported (to reduce mismatched versions between master/stable) #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DanTup merged 1 commit into from
Mar 18, 2019
Merged

Read snippets from Flutter if supported (to reduce mismatched versions between master/stable) #1537

DanTup merged 1 commit into from
Mar 18, 2019

Conversation

@DanTup
Copy link
Member

@DanTup DanTup commented Mar 18, 2019

Fixes #1529.

@DanTup DanTup added is enhancement in flutter Relates to running Flutter apps labels Mar 18, 2019
@DanTup DanTup added this to the v2.25.0 milestone Mar 18, 2019
@DanTup DanTup merged commit ea6d0d5 into master Mar 18, 2019
@DanTup DanTup deleted the flutter-create-list-samples branch March 18, 2019 12:32
@DanTup
Copy link
Member Author

DanTup commented Mar 18, 2019

@pq FYI - this is the change to read snippets from flutter create --list-samples foo. I ditched the embedded array and left the existing web code as a fallback, but may remove the web code after a stable Flutter release includes this command (in which case I'll just show the error that you need a newer Flutter SDK when supportsFlutterCreateListSamples == false).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in flutter Relates to running Flutter apps is enhancement

Projects

None yet

Milestone

v2.25.0

Development

Successfully merging this pull request may close these issues.

2 participants

@DanTup