Skip to content

DevTools processes may not be terminated correctly at shutdown #1511

@DanTup

Description

@DanTup

The process ID is different - this is likely because it's the shell (we use shellExecute) or pub is spawning dart.exe.

(PROC 7152) Spawned /home/travis/build/Dart-Code/Dart-Code/with spaces/dart-sdk/bin/pub global run devtools --machine --port 0
(PROC 7152) {"method":"server.started","params":{"host":"127.0.0.1","port":37077}}
(PROC 7152) Calling kill()
(PROC 7152) Exited with code null
Waiting 10 secs before dumping processes...
(Test end): 7153 (1): dart: /home/travis/build/Dart-Code/Dart-Code/with spaces/dart-sdk/bin/dart /home/travis/build/Dart-Code/Dart-Code/with spaces/dart-sdk/bin/snapshots/pub.dart.snapshot global run devtools --machine --port 0

Opened flutter/devtools#402 to expose the real PID, as we do for other processes.

  • Land fix in DevTools
  • Wait for DevTools release
  • Update minimum required version
  • Fix this to use PID
  • Revert 77271d6

Metadata

Metadata

Assignees

No one assigned

    Labels

    blocked on dart / flutterRequires a change in Dart or Flutter to progressin commandsRelates to commands (usually invoked from the command Palette)is bug

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions