Skip to content

Running a test that outputs Observatory banner in non-debug mode connects to that URL #1449

@DanTup

Description

@DanTup

While running devtools tests (integration/logging) with the Run CodeLens link it was terminating early. Turned out that because we didn't get our own Observatory banner (since we ran without debugger) we were picking up the output from the tests (which spawn a process):

[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"testID":4,"result":"success","skipped":false,"hidden":true,"type":"testDone","time":15431}
[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"group":{"id":5,"suiteID":0,"parentID":3,"name":"integration logging","metadata":{"skip":false,"skipReason":null},"testCount":2,"line":32,"column":5,"url":"file:///Users/dantup/Dev/Google/devtools/packages/devtools/test/integration_tests/integration_test.dart"},"type":"group","time":15432}
[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"test":{"id":6,"name":"integration logging displays log data","suiteID":0,"groupIDs":[2,3,5],"metadata":{"skip":false,"skipReason":null},"line":24,"column":3,"url":"file:///Users/dantup/Dev/Google/devtools/packages/devtools/test/integration_tests/logging.dart","root_line":32,"root_column":5,"root_url":"file:///Users/dantup/Dev/Google/devtools/packages/devtools/test/integration_tests/integration_test.dart"},"type":"testStart","time":15433}
[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"testID":6,"messageType":"print","message":"PID = 16331","type":"print","time":15444}
[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"testID":6,"messageType":"print","message":"16331: Got line: Observatory listening on http://127.0.0.1:52442/","type":"print","time":15521}
[10:20:11 GMT+0000 (GMT)] [Observatory] [Info] Observatory connection closed: 1006 ()
[10:20:11 GMT+0000 (GMT)] [PubTest] [Info] <== {"testID":6,"messageType":"print","message":"16331: Got line: starting logging app","type":"print","time":15783}
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] Disconnect requested!
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] TERM: Going to terminate with SIGINT...
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] TERM: Terminating related process 16285 with SIGINT...
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] TERM: Terminating main process with SIGINT...
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] TERM: Removing all stored data...
[10:20:12 GMT+0000 (GMT)] [Observatory] [Info] TERM: Waiting for process to finish...

We should be a bit more picky about what output we can read this from - we shouldn't be reading it from Pub Test JSON like this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    in debuggingRelates to the debug adapter or process of running debug sessionsis bug

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions