Set default keybindings as in Emacs#67
Set default keybindings as in Emacs#67munen wants to merge 1 commit intoDanielDe:masterfrom munen:set-keybindings-to-emacs-default
Conversation
|
I've actually been thinking of entirely killing the keyboard shortcuts feature since its broken in a bunch of ways, and in most cases you'll have full blown Emacs available to you if you're on your desktop. I'm also inclined to leave the defaults as-is since they work nicely on macOS. Maybe if this is a feature that sticks around we can choose different defaults based on the detected OS. I'm going to close this for now, but am certainly open to being convinced that it should be merged in! |
|
@DanielDe If you want to remove the shortcuts feature, that's your prerogative, as you a the only person wich merge-rights on this repo. However, I'm personally invested in getting org-web bug-free as I want to use it and am currently onboarding other people. Having defaults that only run on macOS are a dealbreaker for the latter. If you're planning to target only macOS for org-web (which imo is a generic web-app), I'm afraid that I will have to make a fork which would be unfortunate since I feel that org-web is just about to get some great traction. Since you've closed this without any kind of discussion, I'll opt to open an issue to discuss steering of this project before I can continue contributing. |
|
Hey @munen, sorry, I certainly didn't mean to offend here. My intention was that we could continue to discuss this, but I'll reopen it to do so. I'm certainly not only targeting macOS with this app! If anything, I'm only targeting mobile browsers. But I probably wasn't clear enough about why I didn't think we should merge this, so I'll try to elaborate on that a bit. First, this feature doesn't work very well. When someone suggested adding it I think I was a bit too eager to please, instead of carefully considering its usefulness and how I'd execute on it. So this seems like the kind of feature that'll take a lot more work before it stops being a source of problems. And since the main target for org-web is mobile browsers, I think it's worth considering just killing the feature outright instead. Second, part of the reason I had chosen some of these default keybindings is to get around some of the shortcomings in the feature, and I had tested these defaults in macOS where they worked well enough. I like the idea of providing different defaults for different browsers, but I wouldn't want to make the experience worse anywhere. Nevertheless, I'll more carefully look at the changes you've requested here. |
| ['Select next header', 'selectNextVisibleHeader', 'ctrl+n'], | ||
| ['Select previous header', 'selectPreviousVisibleHeader', 'ctrl+p'], | ||
| ['Select next header', 'selectNextVisibleHeader', 'ctrl+down'], | ||
| ['Select previous header', 'selectPreviousVisibleHeader', 'ctrl+up'], |
There was a problem hiding this comment.
I don't think "up" and "down" should require the ctrl modifier. But its also possible that this feature doesn't work without a modifier.
| ['Move header up', 'moveHeaderUp', 'alt+up'], | ||
| ['Move header down', 'moveHeaderDown', 'alt+down'], | ||
| ['Move header left', 'moveHeaderLeft', 'alt+shift+left'], | ||
| ['Move header right', 'moveHeaderRight', 'alt+shift+right'], |
There was a problem hiding this comment.
Cases like these seem like low hanging fruit for a simple OS-based default. If on Mac, specifiy command, otherwise specify alt.
| ['Move header down', 'moveHeaderDown', 'ctrl+command+n'], | ||
| ['Move header left', 'moveHeaderLeft', 'ctrl+command+b'], | ||
| ['Move header right', 'moveHeaderRight', 'ctrl+command+f'], | ||
| ['Undo', 'undo', 'ctrl+shift+-'], |
There was a problem hiding this comment.
I'm pretty sure this is the default for undo in Emacs, isn't it?
|
@DanielDe Thank you for re-opening and explaning. I do understand your rationale now. Therefore I concur and will happily close this PR. |
I noticed that some keybindings have a different standard shortcut than in Emacs. For consistency (and to re-use or train muscle memory), imo it's good to have the defaults set the same as in Emacs. Some keybindings are even shorter than what org-web proposed before as default (
ctrl+shift+-to undo unstead ofctrl+/or moving headers around).Some of these changes were done because the keybindings before didn't work as they were caught by the system. For example
ctrl+n,ctrl+pandctrl+tare shortcuts that are already assigned to the browser in Linux and Windows.Note: I'm away from home for the week, so I cannot test this shortcut configuration on a Mac. From memory, I'd say there's no collision with something Mac specific.