tell a surface belongs to the bsp, properly select the renderer#309
Merged
illwieckz merged 2 commits intoDaemonEngine:masterfrom Apr 13, 2020
Merged
tell a surface belongs to the bsp, properly select the renderer#309illwieckz merged 2 commits intoDaemonEngine:masterfrom
illwieckz merged 2 commits intoDaemonEngine:masterfrom
Conversation
Make possible to test if a surface comes for a map model, even if if not world model or there is no lightmap.
Member
Author
|
The bug was found while working on #301 (merge lightmap and vertex (lightgrid) world and entity lighting). |
Member
Author
|
I think there is very low chance this code introduces bugs, at least it's better than what we had before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #302 for explanations about the issue it fixes.
If I color in red what is rendered by
vertexLighting_DBS_entity_fp.glsl, in green what is rendered byvertexLighting_DBS_world_fp.glsland in blue what is rendered bylightMapping_fp.glsl, I get this:While world vertex lighting is disabled:
While world vertex lighting is enabled:
Everything looks fine now, bsp non-world models are not anymore rendered as entities.
There is still cases where surfaces are lightmapped while vertex world lighting is enabled, but that looks to be the bug described in #296.