NUKE LightForPoint function and trap call#1910
Merged
slipher merged 1 commit intoDaemonEngine:for-0.56.0/syncfrom Mar 3, 2026
Merged
NUKE LightForPoint function and trap call#1910slipher merged 1 commit intoDaemonEngine:for-0.56.0/syncfrom
slipher merged 1 commit intoDaemonEngine:for-0.56.0/syncfrom
Conversation
25fd20d to
15d37a3
Compare
15d37a3 to
73bc8f9
Compare
illwieckz
approved these changes
Mar 3, 2026
Member
illwieckz
left a comment
There was a problem hiding this comment.
LGTM.
Sometime I think about having a very cheap grid lighting option that would just use the fullbright render multiplied by the lightgrid color at model origin position. For example if we target Android devices that may not have 3D textures. I guess this could make use of R_LightForPoint(), but we can restore this function if we implement that feature one day, and we would not need the trapping infrastructure in this case (it would be a pure engine-side thing), so we better clean-up that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No hurry on this since it's just deleting unused code. Could wait for 0.56 RC2