Merged
Conversation
a3f497b to
8bf5947
Compare
8bf5947 to
ce3a1cb
Compare
DolceTriade
reviewed
Nov 10, 2024
Contributor
DolceTriade
left a comment
There was a problem hiding this comment.
If they are unused, do you think this change is safe in master (with a corresponding Unvanquished change)? I worry that deleting them in 0.56.0 will allow this to regress.
Member
|
LGTM. Doing it in the 0.56 branch is the right way. Having syscalls that work in some engine builds of the same ABI version but not others wouldn't be good. |
Contributor
|
Fair enough. Probably won't gain any uses of the syscalls and we'll jsut discover it when we release 0.56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.