Fix vertex-lit surfaces with material system#1398
Merged
illwieckz merged 1 commit intoDaemonEngine:masterfrom Oct 28, 2024
Merged
Fix vertex-lit surfaces with material system#1398illwieckz merged 1 commit intoDaemonEngine:masterfrom
illwieckz merged 1 commit intoDaemonEngine:masterfrom
Conversation
Member
|
LGTM |
Member
|
Does it also fix |
Contributor
Author
|
...was it broken? I would need to check because I wasn't aware of that. |
Contributor
Author
Just tried and it does, indeed, fix that. |
Member
|
Yes, I noticed it was broken, but I didn't find time to report it before with the release rush, and since |
73440bc to
61365d6
Compare
Contributor
Author
|
Rebasing first because CI failed to start for some reason. |
9a8a1fa to
10d9f42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't overwrite
tess.svars.colorbyTess_ComputeColor()after setting it withSetVertexLightingSettings(). Fixes some surfaces being whitened out, like crates, bricks and boxes onterminus.