Fix bad 'server.private' behavior for LAN games#1395
Merged
slipher merged 2 commits intoDaemonEngine:masterfrom Oct 30, 2024
Merged
Fix bad 'server.private' behavior for LAN games#1395slipher merged 2 commits intoDaemonEngine:masterfrom
slipher merged 2 commits intoDaemonEngine:masterfrom
Conversation
illwieckz discovered that the default value 3 of cvar server.private on clients made it impossible to see the game in the LAN server list. This mode 3 really makes no sense as it is allowing LAN clients only, but not even allowing them to see the server. server.private was mixing two things: whether the server reports its status and whether it allows non-LAN addresses. Make it control only the former and add sv_networkScope for whether non-LAN addresses are allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.