Skip to content

Fix bad 'server.private' behavior for LAN games#1395

Merged
slipher merged 2 commits intoDaemonEngine:masterfrom
slipher:too-private
Oct 30, 2024
Merged

Fix bad 'server.private' behavior for LAN games#1395
slipher merged 2 commits intoDaemonEngine:masterfrom
slipher:too-private

Conversation

@slipher
Copy link
Copy Markdown
Member

@slipher slipher commented Oct 26, 2024

No description provided.

illwieckz discovered that the default value 3 of cvar server.private
on clients made it impossible to see the game in the LAN server
list. This mode 3 really makes no sense as it is allowing LAN clients
only, but not even allowing them to see the server.

server.private was mixing two things: whether the server reports
its status and whether it allows non-LAN addresses. Make it control only
the former and add sv_networkScope for whether non-LAN addresses are
allowed.
Copy link
Copy Markdown
Member

@illwieckz illwieckz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slipher slipher merged commit 145b361 into DaemonEngine:master Oct 30, 2024
@slipher slipher deleted the too-private branch January 9, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants