Detect RV300 and VC4 hardware and disable slow half float vertex on them#1347
Detect RV300 and VC4 hardware and disable slow half float vertex on them#1347illwieckz merged 2 commits intofor-0.55.0/syncfrom
Conversation
7ab7dd7 to
9da022d
Compare
|
I also added VC4 detection, it's twice faster with float vertex on it. Before (25fps):
After (55fps):
|
src/engine/sys/sdl_glimp.cpp
Outdated
|
|
||
| if ( !halfFloatVertexEnabled ) | ||
| { | ||
| logger.Warn( "Missing half-float vertex, using float vertex instead." ); |
There was a problem hiding this comment.
How about Notice for this one. We shouldn't use Warn so much unless there is a serious problem.
There was a problem hiding this comment.
I like to have a bolder log for such things, especially when it is reporting about making decisions, it makes it easier to catch them in logs. Though I agree Warn is maybe too much.
9da022d to
d4a3c5c
Compare
|
I addressed the various comments. |
Forgot to push something? I don't see any new stuff. |
d4a3c5c to
3cbd0a7
Compare
Indeed, now fixed. |
|
LGTM |
Import from:
ARB_half_float_vertex#1179