Conversation
…uxeLight and computeDynamicLights
illwieckz
commented
Jan 23, 2024
Member
|
"Directional light" is a term of art (see this for example) meaning something else, so it would be better to avoid this name. |
Member
Author
|
At first I wrote “DeluxeLight”, I don't know if that means something, but at least in this context we would know what it is about. |
Member
|
DeluxeLight works for me. |
Member
Author
|
What about |
Member
Author
|
Well, computing specular light is only a subset of that compute… |
5277d07 to
d41d232
Compare
Member
Author
|
I've set |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make GLSL code easier to read with computeLight, computeDirectionalLight and computeDynamicLights.
The real magic is in
lightMapping_fp.glsl, it makes easier to spot the actual alternative code to directional light computation that was previously disseminated everywhere, we now have a simple if/else condition calling one or the other function.