Code Review — findings and fixes (ranked by severity)

Fixes were pushed in commit f33592c directly to this branch.

🔴 HIGH — UpdateState.copyWith could never clear stagedArchivePath / preparedVersion (fixed)

File: lib/features/updates/controllers/update_controller.dart

copyWith used stagedArchivePath ?? this.stagedArchivePath, meaning once set, neither field could ever be reset to null. This caused a real bug on Android: after applyUpdate() completes and transitions to phase: idle, the stale stagedArchivePath (and matching preparedVersion) remained in state. The next periodic check() call triggers unawaited(prepareUpdate()), which guards against re-downloading only when phase == ready && preparedVersion == version. Since phase had just been set back to idle, this guard never fires — the controller starts a redundant full re-download of the same build the user just applied.

Fix: Added bool clearStagedArchive = false and bool clearPreparedVersion = false flags to copyWith, and used them when applyUpdate transitions to idle:

state = state.copyWith(
  phase: UpdatePhase.idle,
  clearStagedArchive: true,
  clearPreparedVersion: true,
);

🟡 MEDIUM — Missing tests for new state getters and banner states (fixed)

Files: test/features/updates/update_controller_test.dart, test/features/updates/update_banner_test.dart

The PR introduced several new computed properties (updateReady, downloading, the ready phase exclusion from installing) and new banner paths (updateReady banner, fallback on failed download) with zero test coverage.

Added:

• UpdateState.updateReady — true only when phase == ready && stagedArchivePath != null
• UpdateState.downloading — true for downloading and verifying only
• UpdateState.installing — explicitly asserts that ready is excluded (the key invariant enabling the one-click UX)
• UpdateState.copyWith clear flags — both clearStagedArchive and clearPreparedVersion, individually and combined
• UpdateBanner — "restart & install" text when updateReady
• UpdateBanner — fallback "update available" banner when phase is failed

🟢 LOW — Formatting artifact in accord_home_tabs.dart (fixed)

File: lib/features/spaces/views/accord_home_tabs.dart

A trailing comma inside ScaffoldMessenger.of(context,) caused the auto-formatter to split the call across three lines:

// before
ScaffoldMessenger.of(
  context,
).showSnackBar(...);

// after
ScaffoldMessenger.of(context)
    .showSnackBar(...);

ℹ️ Notes (no code change needed)

thread_view.dart — share menu silently omits the web link: When spaceControllerProvider or accordChannelsControllerProvider haven't loaded, the "Share with the internet" option is omitted without any user feedback. This is intentional graceful degradation (the app-link option always shows), but worth documenting that the web link requires both the space slug and channel name to be cached.

update_banner.dart — no loading indicator during apply: While applyUpdate is in flight the banner's onTap is null (disabled), but there's no spinner or "Installing…" text to explain why. The Updates page does show progress, so this is only a UX gap on the banner itself — out of scope for this PR but worth a follow-up.

Generated by Claude Code