chore: update Apple bundle id to com.cattrall.daccord#124
Merged
Conversation
Match the iOS and macOS PRODUCT_BUNDLE_IDENTIFIER (and RunnerTests suffixes) to the App ID registered in the Apple Developer portal (com.cattrall.daccord, Team 8MVM4FMRRC). Android applicationId (com.daccord_projects.daccord) is unchanged, as it is a separate Google Play identifier. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
Code Review —
|
| Severity | Area | Finding |
|---|---|---|
| ✅ None | Completeness | All 3 iOS build configurations (Debug / Release / Profile) for the main Runner target are updated. |
| ✅ None | Completeness | All 3 iOS build configurations for RunnerTests are updated. |
| ✅ None | Completeness | All 3 macOS build configurations for RunnerTests are updated in macos/Runner.xcodeproj/project.pbxproj. |
| ✅ None | macOS main target | The macOS main Daccord target has no PRODUCT_BUNDLE_IDENTIFIER in project.pbxproj — it inherits from AppInfo.xcconfig, which is correctly updated. |
| ✅ None | Info.plist | Both ios/Runner/Info.plist and macos/Runner/Info.plist use $(PRODUCT_BUNDLE_IDENTIFIER) variable expansion — no hardcoded value to update. |
| ✅ None | Entitlements | macos/Runner/DebugProfile.entitlements and Release.entitlements contain no bundle ID references. |
| ✅ None | URL scheme | CFBundleURLName is dev.daccord (not the bundle identifier) — no change needed. |
| ✅ None | Stale references | Global search for com.daccord-projects.daccord across all source, config, and plist files returns zero hits. |
| ✅ None | Test coverage | Config-only change; no app logic altered, no tests to add or update. |
| ✅ None | Android | applicationId (com.daccord_projects.daccord) is a separate Google Play identifier — correctly left unchanged. |
No fixes required
No commits pushed — the PR is already correct and complete as authored. Ready to merge.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the iOS and macOS
PRODUCT_BUNDLE_IDENTIFIERfromcom.daccord-projects.daccordtocom.cattrall.daccordto match the App ID newly registered in the Apple Developer portal (Team8MVM4FMRRC).Changes
ios/Runner.xcodeproj/project.pbxproj— main Runner target +.RunnerTestsmacos/Runner.xcodeproj/project.pbxproj—.RunnerTeststargetsmacos/Runner/Configs/AppInfo.xcconfig— macOS app bundle idNot changed
applicationId(com.daccord_projects.daccord) — separate Google Play identifier, not governed by the Apple App ID.markdown_viewerexample project (com.example.*) — vendored package, out of scope.Notes
No App ID capabilities were enabled on the new identifier; the app uses only sandbox device permissions (camera/mic/network) and a custom
daccord://URL scheme, none of which require portal capability toggles.🤖 Generated with Claude Code