Code Review — findings & fixes (commit 624bd9a)

The core one-line DSN change is correct and focused. Two improvements were pushed on top of it, ranked by severity:

🟡 Medium — Missing regression test for the DSN constant

Finding: The existing test 'the dev DSN is used when no dart-define override is set' only asserts resolveGlitchTipDsn() == kDefaultGlitchTipDsn — a tautology that passes regardless of the constant's value. If the DSN were silently reverted or typo'd to point at the wrong project, no test would catch it.

Fix applied: Added a new test that parses kDefaultGlitchTipDsn through GlitchTipClient.init() and asserts the derived store URL contains /api/2/store/:

test('kDefaultGlitchTipDsn is parseable and targets project 2', () {
  final c = GlitchTipClient();
  expect(c.init(kDefaultGlitchTipDsn), isTrue, reason: '...');
  expect(c.storeUrl, contains('/api/2/store/'), reason: '...');
});

This test would have caught the project-1 → project-2 bug this PR fixes.

🟢 Low — Silent HTTP 4xx/5xx failures in GlitchTipClient._sendEvent

Finding: _sendEvent discarded the HTTP response entirely. If the DSN key or project ID were wrong, every event would silently return a 401/404 with zero developer feedback — exactly the failure mode that motivated this PR.

Fix applied: The response is now captured; in debug mode, any 4xx/5xx logs to debugPrint with the store URL. The "never throw" invariant is preserved — the log is inside the existing try block, which swallows exceptions from post itself.

final response = await _http.post(...);
if (kDebugMode && response.statusCode >= 400) {
  debugPrint('[GlitchTip] event rejected: HTTP ${response.statusCode} (store URL: $_storeUrl)');
}

✅ No issues found

• File size: both files are well under 1000 lines (controller: ~185 lines, client: ~210 lines, test: ~345 lines).
• Code quality: scrubPiiText, _truncateId, breadcrumb ring-buffer, _hooksInstalled guard, and ref.onDispose teardown are all correct.
• Opt-in invariant: confirmed — nothing is sent until errorReportingEnabled is true; the consent flags survive JSON round-trip (covered by existing tests).
• Action item from PR description: the SENTRY_DSN GitHub secret should still be updated to the project-2 key if set — this is outside the scope of this code change.

Generated by Claude Code