fix(auth): reject email addresses as usernames on registration (#24)#25
Merged
Conversation
) Registration only validated username length, so email addresses like user@example.com were accepted as usernames. Since login looks users up by username (a public identifier), this is confusing and undesirable. Add a validate_username helper that rejects any username containing '@', restricts the charset to lowercase [a-z0-9_.], and forbids leading or trailing '.'. Applied to both register() and the username-update endpoint. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #24. The registration endpoint only validated username length, so an email address like
user@example.comwas accepted as a username. Because login looks users up byusername(a public identifier), allowing emails is confusing and undesirable.What changed
validate_usernamehelper insrc/routes/auth.rsthat:@→400 "username may not be an email address"[a-z0-9_.].register()after the existing length check.update_current_user()insrc/routes/users.rs(as suggested in the issue).tests/e2e.rscovering email-shaped usernames and invalid charsets (uppercase, spaces, leading/trailing dots).Reviewer notes
Test plan
cargo test --test e2e register— all 6 register tests pass (including 2 new ones)cargo checkclean