Skip to content

Conversation

@Paddy0523
Copy link
Contributor

… use "*" in columnInfo

Purpose of this pull request

1.get metadata from resultSetMetaData 2.support customSql use "*" in columnInfo

Which issue you fix

Fixes # (issue).
#1284

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@Paddy0523
Copy link
Contributor Author

@liumengkai
Copy link
Contributor

LGTM

@FlechazoW
Copy link
Member

+1

@FlechazoW FlechazoW merged commit 6b4add6 into DTStack:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][chunjun-connector-jdbc-base] when custom sql is not empty,all column type need to be set in config

3 participants