Skip to content

[hotfix] ftp writer format null #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ll076110 merged 2 commits into from
Sep 28, 2022
Merged

[hotfix] ftp writer format null #1264

ll076110 merged 2 commits into from
Sep 28, 2022

Conversation

@chenghb606
Copy link
Contributor

@chenghb606 chenghb606 commented Sep 16, 2022

Purpose of this pull request

Which issue you fix

Fixes # (issue).

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

ll076110
ll076110 reviewed Sep 16, 2022
View reviewed changes
...njun-connector-ftp/src/main/java/com/dtstack/chunjun/connector/ftp/sink/FtpOutputFormat.java
this.ftpHandler.logoutFtpServer();
} catch (Exception e) {
throw new ChunJunRuntimeException("can't close source.", e);
}
Copy link
Contributor

@ll076110 ll076110 Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the error is still not closed, you need to close in the finally block

@FlechazoW
Copy link
Member

FlechazoW commented Sep 20, 2022

Please modify the code, and we will merge it.

@FlechazoW
Copy link
Member

FlechazoW commented Sep 23, 2022

If the error is still not closed, you need to close in the finally block.

Please modify the code, and we will merge it.

@ll076110 ll076110 linked an issue Sep 28, 2022 that may be closed by this pull request
ftp作为sink，报错空指针，FtpOutputFormat未进行实例化 #1282
Closed
3 tasks
@ll076110 ll076110 added the bug Something isn't working label Sep 28, 2022
@ll076110 ll076110 merged commit 96a60f0 into DTStack:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ll076110 ll076110 ll076110 left review comments

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ftp作为sink，报错空指针，FtpOutputFormat未进行实例化

3 participants

@chenghb606 @FlechazoW @ll076110