Skip to content

Conversation

@Kyofin
Copy link
Contributor

@Kyofin Kyofin commented Sep 10, 2022

Purpose of this pull request

add iceberg connector

Which issue you fix

Feature #1094

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@FlechazoW
Copy link
Member

The ci/cd of this pr is failed because of code format check. You need execute 'mvn spotless:apply' to format the code.
image

Signed-off-by: huzk <1040080742@qq.com>
@FlechazoW FlechazoW merged commit c455e77 into DTStack:master Sep 14, 2022
@FlechazoW
Copy link
Member

close #1094

@ll076110
Copy link
Contributor

Can you provide a usage document, it will be more friendly to others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants