Skip to content

Conversation

@mggger
Copy link
Contributor

@mggger mggger commented Sep 8, 2022

Purpose of this pull request

add emqx container

Which issue you fix

Fixes #1235 .

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@@ -0,0 +1,41 @@
package com.dtstack.chunjun.connector.containers.emqx;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add license please.

/**
* @author kungen@dtstack.com
* @Date 2022/9/7
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the company info.

@@ -0,0 +1,68 @@
package com.dtstack.chunjun.connector.test.standalone.emqx;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add license please.

/**
* @author kungen@dtstack.com
* @Date 2022/9/7
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the company info.

@FlechazoW FlechazoW merged commit 874f86c into DTStack:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][e2e] add emqx container

2 participants