Skip to content

Conversation

@mggger
Copy link
Contributor

@mggger mggger commented Aug 19, 2022

Purpose of this pull request

Not support NullColumn, it will cause cast execption

Which issue you fix

Fixes #1155 .

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@mggger mggger requested a review from yanghuaiGit August 19, 2022 11:08
Copy link
Contributor

@Paddy0523 Paddy0523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should let JdbcRowConverter override AbstractRowConverter#wrapIntoNullableInternalConverter

@mggger
Copy link
Contributor Author

mggger commented Aug 22, 2022

@PaddyMelody please review again

@Paddy0523
Copy link
Contributor

LGTM
@FlechazoW

@FlechazoW FlechazoW merged commit 0278622 into DTStack:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] postgresql-x => postgresql-x local 模式 字段 NULL 异常

3 participants