Skip to content

[hotfix-1097] 修复数据库字段为null时，同步空指针问题 #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FlechazoW merged 1 commit into from
Jul 29, 2022
Merged

[hotfix-1097] 修复数据库字段为null时，同步空指针问题 #1099

FlechazoW merged 1 commit into from
Jul 29, 2022

Conversation

@kinoxyz1
Copy link
Member

@kinoxyz1 kinoxyz1 commented Jul 28, 2022 •
edited by FlechazoW
Loading

Purpose of this pull request

Which issue you fix

Fixes #1097.

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@ll076110
Copy link
Contributor

ll076110 commented Jul 29, 2022

Could you try the val.isNullAt (int pos) method?

@kinoxyz1
Copy link
Member Author

kinoxyz1 commented Jul 29, 2022

Could you try the val.isNullAt (int pos) method?

It has been modified.

FlechazoW
FlechazoW reviewed Jul 29, 2022
View reviewed changes
...dbc-base/src/main/java/com/dtstack/chunjun/connector/jdbc/converter/JdbcColumnConverter.java Outdated
import com.dtstack.chunjun.element.column.BigDecimalColumn;
import com.dtstack.chunjun.element.column.BooleanColumn;
import com.dtstack.chunjun.element.column.BytesColumn;
import com.dtstack.chunjun.element.column.NullColumn;
Copy link
Member

@FlechazoW FlechazoW Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useless imports.

@FlechazoW FlechazoW merged commit e2fa9fd into DTStack:master Jul 29, 2022
@kinoxyz1 kinoxyz1 deleted the hotfix_master_1097 branch July 29, 2022 08:45
@kinoxyz1 kinoxyz1 mentioned this pull request Aug 1, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlechazoW FlechazoW FlechazoW left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [chunjun-connection] 数据库字段为null时，同步空指针

3 participants

@kinoxyz1 @ll076110 @FlechazoW